Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for lazydesigners/the30 #340

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add support for lazydesigners/the30 #340

merged 1 commit into from
Oct 19, 2020

Conversation

jackytrabbit
Copy link
Contributor

Add support for lazydesigners/the30

Description

QMK Pull Request

qmk/qmk_firmware#10374

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

2Moons-JP
2Moons-JP approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@2Moons-JP 2Moons-JP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually checked this against the QMK VIA keymap and the .h file. Everything looks good.

@wilba wilba merged commit 98f0d0e into the-via:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2Moons-JP 2Moons-JP 2Moons-JP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackytrabbit @2Moons-JP @wilba